Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit099a045

Browse files
committed
fix cache miss metrics
1 parent6d99656 commit099a045

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

‎dora/core/client/fs/src/main/java/alluxio/client/file/cache/LocalCacheManager.java‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -225,6 +225,9 @@ public Optional<DataFileChannel> getDataFileChannel(
225225
MetricsSystem.meter(MetricKey.CLIENT_CACHE_BYTES_READ_CACHE.getName()).mark(bytesToRead);
226226
cacheContext.incrementCounter(MetricKey.CLIENT_CACHE_BYTES_READ_CACHE.getMetricName(),BYTE,
227227
bytesToRead);
228+
cacheContext.incrementCounter(
229+
MetricKey.CLIENT_CACHE_PAGE_READ_CACHE_TIME_NS.getMetricName(),NANO,
230+
System.nanoTime() -startTime);
228231
LOG.debug("getDataChannel({},pageOffset={}) exits",pageId,pageOffset);
229232
returnOptional.of(dataFileChannel);
230233
}catch (PageNotFoundExceptione) {
@@ -242,10 +245,6 @@ public Optional<DataFileChannel> getDataFileChannel(
242245
returnOptional.empty();
243246
}
244247
}
245-
}finally {
246-
cacheContext.incrementCounter(
247-
MetricKey.CLIENT_CACHE_PAGE_READ_CACHE_TIME_NS.getMetricName(),NANO,
248-
System.nanoTime() -startTime);
249248
}
250249
}
251250

@@ -642,12 +641,10 @@ public int get(PageId pageId, int pageOffset, int bytesToRead, ReadTargetBuffer
642641
MetricsSystem.meter(MetricKey.CLIENT_CACHE_BYTES_READ_CACHE.getName()).mark(bytesRead);
643642
cacheContext.incrementCounter(MetricKey.CLIENT_CACHE_BYTES_READ_CACHE.getMetricName(),BYTE,
644643
bytesRead);
644+
cacheContext.incrementCounter(MetricKey.CLIENT_CACHE_PAGE_READ_CACHE_TIME_NS.getMetricName(),
645+
NANO,System.nanoTime() -startTime);
645646
LOG.debug("get({},pageOffset={}) exits",pageId,pageOffset);
646647
returnbytesRead;
647-
}finally {
648-
cacheContext.incrementCounter(
649-
MetricKey.CLIENT_CACHE_PAGE_READ_CACHE_TIME_NS.getMetricName(),NANO,
650-
System.nanoTime() -startTime);
651648
}
652649
}
653650

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp