- Notifications
You must be signed in to change notification settings - Fork206
RFC: First approach to add target specific intriniscs for gfx90a targets#1796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:develop
Are you sure you want to change the base?
RFC: First approach to add target specific intriniscs for gfx90a targets#1796
Uh oh!
There was an error while loading.Please reload this page.
Conversation
illuhad commentedMay 5, 2025
Why do we need a new bitcode file? Could we just not implement the unsafe atomic add in the existing one with some JIT reflection? |
sbalint98 commentedMay 6, 2025
Unfortunately, clang will choke on these builtins if there is no appropriate Compiling it without specifying gfx90a target arch results in the following error: Which is as far as I can tell is due to checking the sub-target compatibility of the builtin by the frontend here: There are some exceptions made for compiling when targeting Additionally the |
This MR is an initial experimental approach to add target specific sscp builtins. In particular the hip unsafe atomics is exposed through the
hipsycl::sycl::detail::__acpp_unsafe_atomic_fetch_addfunction. It could be used by calling into AdaptiveCpp details the following way: