Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix undefined aliasing issue when compiling with clang-cl#1786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
bgottamd wants to merge1 commit intoAcademySoftwareFoundation:master
base:master
Choose a base branch
Loading
frombgottamd:clang-cl-compat-fix

Conversation

@bgottamd
Copy link

Fixes theinner ValueT alias throw an undefined error when compiling with clang/clang-cl on Windows by converting theconvertValue into a template function.

@linux-foundation-easycla
Copy link

linux-foundation-easyclabot commentedApr 4, 2024
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

…ang-cl.ResolvesAcademySoftwareFoundation#1785Signed-off-by: bgottamd <Benjamin.Gottheil@amd.com>
@bgottamdbgottamd marked this pull request as ready for reviewApril 4, 2024 23:20
@bgottamd
Copy link
Author

Adding a quick bump. This small code change is essential so that Blender can support both clang -merged PR here - and openvdb. Without it, blender fails to build due to the cited issue.

@LazyDodo
Copy link

any progress here? We'd like to get this working out of the box for blender, and while i have no issue including selected upstream landed patches for our dependencies, upstream unreviewed patches are a bit of a different story.

@jo-rn
Copy link

I've hit the same clang bug before and reported it:llvm/llvm-project#64996. Using-fno-delayed-template-parsing, as was suggested there, makes OpenVDB compile successfully with clang-cl.

@bgottamd
Copy link
Author

Thanks@jo-rn - this does fix the issue with the header file compilation in blender. However, there is some performance degradation when this flag is used:

Fileargsfastestslowestavg
classroom3840x2160 256 samplesheader template fix120912171213
-fno-delayed-template-parsing121812281223

This equates to ~1% drop in performance just from this flag. Hoping this templating change or a modification of the alias can still be merged in.

@LazyDodo
Copy link

Odd result, classroom is a blender 2.79 scene, openvdb wasn't integrated till blender 2.83, so the odds of it having an openvdb volume has to be near the low end of things. Did you put the-fno-delayed-template-parsing flag globally on the whole blender project? or isolated it to just the few openvdb related files that needed this fix?

@bgottamd
Copy link
Author

bgottamd commentedJul 19, 2024
edited
Loading

I isolated the flag to projects that complained about the header issue. This ended up being onlyextern_mantaflow andcycles_scene

@anthony-linaro
Copy link

For those keeping track of this issue affecting Blender, I have created a PR to work around the issue using the approach described in this thread:https://projects.blender.org/blender/blender/pulls/126236

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@kmusethkmusethAwaiting requested review from kmusethkmuseth is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bgottamd@LazyDodo@jo-rn@anthony-linaro

[8]ページ先頭

©2009-2025 Movatter.jp