- Notifications
You must be signed in to change notification settings - Fork718
Fix undefined aliasing issue when compiling with clang-cl#1786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Fix undefined aliasing issue when compiling with clang-cl#1786
Uh oh!
There was an error while loading.Please reload this page.
Conversation
linux-foundation-easyclabot commentedApr 4, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
|
…ang-cl.ResolvesAcademySoftwareFoundation#1785Signed-off-by: bgottamd <Benjamin.Gottheil@amd.com>
Adding a quick bump. This small code change is essential so that Blender can support both clang -merged PR here - and openvdb. Without it, blender fails to build due to the cited issue. |
LazyDodo commentedJun 6, 2024
any progress here? We'd like to get this working out of the box for blender, and while i have no issue including selected upstream landed patches for our dependencies, upstream unreviewed patches are a bit of a different story. |
jo-rn commentedJul 5, 2024
I've hit the same clang bug before and reported it:llvm/llvm-project#64996. Using |
Thanks@jo-rn - this does fix the issue with the header file compilation in blender. However, there is some performance degradation when this flag is used:
This equates to ~1% drop in performance just from this flag. Hoping this templating change or a modification of the alias can still be merged in. |
LazyDodo commentedJul 19, 2024
Odd result, classroom is a blender 2.79 scene, openvdb wasn't integrated till blender 2.83, so the odds of it having an openvdb volume has to be near the low end of things. Did you put the |
bgottamd commentedJul 19, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I isolated the flag to projects that complained about the header issue. This ended up being only |
anthony-linaro commentedAug 13, 2024
For those keeping track of this issue affecting Blender, I have created a PR to work around the issue using the approach described in this thread:https://projects.blender.org/blender/blender/pulls/126236 |
Fixes theinner ValueT alias throw an undefined error when compiling with clang/clang-cl on Windows by converting the
convertValueinto a template function.