- Notifications
You must be signed in to change notification settings - Fork718
Removed Redundant Render Function Call#1686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
ganesh1828 wants to merge2 commits intoAcademySoftwareFoundation:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Removed Redundant Render Function Call#1686
ganesh1828 wants to merge2 commits intoAcademySoftwareFoundation:masterfromganesh1828:Deprecating_Redundant_Render_Function_Call
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
linux-foundation-easyclabot commentedOct 13, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
|
Signed-off-by: Ganesh Suresh Kandepalli <81383406+ganesh1828@users.noreply.github.com>
diiigle commentedOct 14, 2023
Rings some alarm bells for me:
smells fishy |
@diiigle Binary was pushed by mistake, that's why I removed it. and description is provided now, you can check it. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Due to mUpdates upper limit value check 2, render function is called twice from the loop in the view function in the Viewer.cc file.
Changing its upper limit value check to 1 will results in calling render function only once.