Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Use location instead of the undefined query property#100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
kyusu wants to merge1 commit into60frames:master
base:master
Choose a base branch
Loading
fromkyusu:master

Conversation

@kyusu
Copy link

Hi@richardscarrott,

I've found something which I consider a minor bug in your boilerplate. In thefetchComponentDatain theserver.js you are destructuring therenderProps intoquery,params andhistory. Butquery is undefined. If I want to access the query parameters, I first have to get thelocation property and then access thequery.

@kyusu
Copy link
Author

Hmm, interesting the checks fail for files I haven't touched.

@richardscarrott
Copy link
Member

richardscarrott commentedAug 17, 2017
edited
Loading

@kyusu good catch... it also looks likehistory is undefined.

There doesn't appear to be much in the way of documentation forrenderProps in the RR repo but I'm guessing it must have been removed when I upgraded to RR 3.x -- would you mind updating this to pass in justdispatch,params and the entirelocation object, e.g.

const{ location, params}=renderProps;return(component.fetchData({dispatch:store.dispatch,            location,            params})// Make sure promise always successfully resolves.catch(()=>{}));

re: CI, it looks like there's a mismatched version of prettier -- if you make the above change I'll fix that up and merge it in.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kyusu@richardscarrott

[8]ページ先頭

©2009-2025 Movatter.jp