- Notifications
You must be signed in to change notification settings - Fork12
Use location instead of the undefined query property#100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Hmm, interesting the checks fail for files I haven't touched. |
richardscarrott commentedAug 17, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@kyusu good catch... it also looks like There doesn't appear to be much in the way of documentation for const{ location, params}=renderProps;return(component.fetchData({dispatch:store.dispatch, location, params})// Make sure promise always successfully resolves.catch(()=>{})); re: CI, it looks like there's a mismatched version of prettier -- if you make the above change I'll fix that up and merge it in. |
Hi@richardscarrott,
I've found something which I consider a minor bug in your boilerplate. In the
fetchComponentDatain theserver.jsyou are destructuring therenderPropsintoquery,paramsandhistory. Butqueryis undefined. If I want to access the query parameters, I first have to get thelocationproperty and then access thequery.